C++: Support for & and >> in SimpleRangeAnalysis#3277
Merged
Conversation
dbartol
reviewed
Apr 16, 2020
dbartol
reviewed
Apr 21, 2020
dbartol
left a comment
dbartol
left a comment
There was a problem hiding this comment.
Other than the two more suggested getFullyConverted()s, LGTM.
Co-Authored-By: Dave Bartolomeo <dbartol@github.com>
Contributor
Author
|
Thanks @dbartol ! |
dbartol
approved these changes
Apr 22, 2020
jbj
reviewed
Apr 27, 2020
| exists(RShiftExpr rsExpr, float left, int right | | ||
| rsExpr = expr and | ||
| left = getFullyConvertedUpperBounds(rsExpr.getLeftOperand()) and | ||
| right = rsExpr.getRightOperand().getValue().toInt() and |
Contributor
There was a problem hiding this comment.
I think this should have .getFullyConverted().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for bitwise
&and>>(by a constant) in SimpleRangeAnalysis.qll. This will fix #3247.I've done a bit of performance testing locally, and the query seems to be up to 2% slower in the cases where I can measure a difference.